Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 33464: /trunk/epan/dissectors/ /trun
From: Gerald Combs <[email protected]>
Date: Wed, 07 Jul 2010 11:53:47 -0700
Jeff Morriss wrote:
> Gerald Combs wrote:
>> [email protected] wrote:
>>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=33464
>>>
>>> User: morriss
>>> Date: 2010/07/07 08:52 AM
>>>
>>> Log:
>>>  Fix infinite recursion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4984 : In try_get_ber_length() make sure we move forward before recursing.
>>>
>>> Directory: /trunk/epan/dissectors/
>>>   Changes    Path            Action
>>>   +57 -56    packet-ber.c    Modified
>> If I apply the attached debugging code to packet-ber.c I see some high
>> stack counts in the fuzz capture from bug 4984. It looks like we're
>> still vulnerable to a stack overflow.
> 
> Interesting--I don't get any stacks deeper than 10 on that capture file.

Oops - that should be bug 4951. I get 162 on that one.