Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] Kerberos pre-auth type constants - MS extensions are wrong?

From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Mon, 3 May 2010 15:47:38 +0200
Hi,
Note that packet-kerberos-template.c isn't used to generate packet-kerberos.c currently, I would guess
that the info in packet-kerberos-template.c is copied from the current hand written dissector.
Regards
Anders


From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Kaul
Sent: den 3 maj 2010 14:04
To: Developer support list for Wireshark
Subject: [Wireshark-dev] Kerberos pre-auth type constants - MS extensions are wrong?

It appears like MS extensions for Kerberos pre-auth type constants, such as:
#define KRB5_PA_PAC_REQUEST         -128  /* = 0xFFFFFF80 = (gint32)((gint8)0x80) MS extension */

are wrong - should be 128 (which is 0x80 btw), for example, based on a capture I've done and on http://download.microsoft.com/download/a/e/6/ae6e4142-aa58-45c6-8dcf-a657e5900cd3/%5BMS-KILE%5D.pdf (see section 3.1.5.1)
Is it OK to fix them in packet-kerberos-template.c? Anyone knows where the mistake comes from?

TIA,
Y.