On Wed, Feb 24, 2010 at 12:48:39AM +0100, Jakub Zawadzki wrote:
> On Tue, Feb 23, 2010 at 02:39:31PM -0800, buildbot-no-reply@xxxxxxxxxxxxx wrote:
> Blamelist: darkjames
>
> I moved bytes_to_str & bytes_to_str_punct from strutil.c to to_str.c ;/
>
> Naive change in Makefile.am:
>
> -reassemble_test: reassemble_test.o tvbuff.o except.o strutil.o emem.o \
> +reassemble_test: reassemble_test.o tvbuff.o except.o strutil.o emem.o to_str.o \
>
> Makes much more linking trouble...
> wireshark/epan/to_str.c:1211: undefined reference to `sna_fid_to_str_buf'
> wireshark/epan/to_str.c:1215: undefined reference to `atalk_addr_to_str_buf'
> wireshark/epan/to_str.c:1224: undefined reference to `print_nsap_net_buf'
> wireshark/epan/to_str.c:1234: undefined reference to `mtp3_addr_to_str_buf'
> [...]
>
> I think it would be good idea to make tests (or at least reassemble one) link with libwireshark, instead of object files...
Attaching patch to move address to string functions (except ip_to_str_buf), to new address_to_str.c.
No changes inside header files.
Attachment:
fix-test-compilation.patch.gz
Description: GNU Zip compressed data
