Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] enum or #define?

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Mon, 15 Feb 2010 07:49:22 +0100
Hi,

That would probably be #1.
This option makes verification against a protocol spec / RFC easiest, also such values don't have to be sequential.

Thanks,
Jaap

Send from my iPhone

On 14 feb 2010, at 22:21, Kaul <mykaul@xxxxxxxxx> wrote:

Which one is better?
option 1:
#define SSL_HND_HELLO_REQUEST          0
#define SSL_HND_CLIENT_HELLO           1
...

or perhaps, option 2:
enum {
SSL_HND_HELLO_REQUEST,
SSL_HND_CLIENT_HELLO,
};
...

and then (in both cases):

const value_string ssl_31_handshake_type[] = {
    { SSL_HND_HELLO_REQUEST,     "Hello Request" },
    { SSL_HND_CLIENT_HELLO,      "Client Hello" },


?

TIA,
Y.

___________________________________________________________________________


Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe