Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 31832: /trunk/epan/dissectors/ /trun

From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Wed, 10 Feb 2010 21:46:20 +0100

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Joerg Mayer
Sent: den 10 februari 2010 21:15
To: wireshark-dev@xxxxxxxxxxxxx
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 31832: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sflow.c

On Mon, Feb 08, 2010 at 09:01:24PM +0000, etxrab@xxxxxxxxxxxxx wrote:

>> Log:
>>  From Yi Yu:
>>  Enhanced sFlow dissector.
>> Directory: /trunk/epan/dissectors/
>>   Changes    Path              Action
>>   +3197 -1879 packet-sflow.c    Modified
>If you feel like replacing the sflow dissector by another implementation, maybe you should consider whether this >really improves it:
>The previous version had a total of 8 ..._add_text, the replacemnt has 206, i.e. the filter capabilities just 
>took a big step backwards.
> ciao
>     Joerg
You were asked to comment on it 4 moth ago ;)
>Comment 35 Kovarththanan Rajaratnam 2009-09-23 21:31:32 PDT 
>Jörg, do you have time or intend to review this patch? I'm asking because we
>have some fuzz bugs (bug 3882  and 3888) lying around and it might not be worth
>it to fix those bugs if this patch completely rewrites the sFlow dissector.

I don't have a problem with you reverting it.
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>