Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 4339] [PATCH] VNC dissector cleanups and minor changes

[Bill Meier <wmeier@xxxxxxxxxxx>]

bugzilla-daemon@xxxxxxxxxxxxx wrote:
> I'm not sure what the consequence of the removal of the 2nd
> 'heur_dissector_add("tcp", test_vnc_protocol, proto_vnc);' line.
>
> I've added it in rev. 28394, can't see the logic why it was added twice (and
> why not remove the first call to it).

If I understand your question correctly: heur_dissector_add needs to be 
called only once (ie the first time reg_handoff_vnc is called).