Wireshark-dev: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
From: "Anders Broman" <anders.broman@xxxxxxxxxxxx>
Date: Thu, 22 Oct 2009 10:57:30 +0200
Hi, I'm currently on a buissiness trip and have little spare time :( I can live with Lars'es solution but fear that there may be deeper issues... See http://www.wireshark.org/lists/wireshark-dev/200910/msg00194.html I'm not sure my GTK knowledge Is good enough to fix this. Regards Anders -----Original Message----- From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Jaap Keuter Sent: den 22 oktober 2009 09:14 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour Hi All, Since Gerald is preping 1.2.3 it's time to get this finished. Anders, as a Windows core developer, can you pick this up? Thanx, Jaap Anders Broman wrote: > Hi, > Perhaps it only happens if you have the console window open? > Regards > Anders > > -----Original Message----- > From: wireshark-dev-bounces@xxxxxxxxxxxxx > [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of RUOFF LARS > Sent: den 14 oktober 2009 13:55 > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour > > > Hi Anders, > Hmm, I can't reproduce this. > I compiled 1.3.0 with the line from gtk/dlg_utils.c commented out and > it works just fine. > When I close Wireshark, all child windows close nicely. > Will try the same on trunk as soon as I have recompiled after > distclean > :-) > > Lars > > > >> -----Original Message----- >> From: wireshark-dev-bounces@xxxxxxxxxxxxx >> [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Anders >> Broman >> Sent: mercredi 14 octobre 2009 12:04 >> To: Developer support list for Wireshark >> Subject: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour >> >> >> Hi, >> Written in a hurry :-) >>> Is there any particular reason we need to have the windows >> transient to >> top level? >> >> If you do not use transent and leave the child window open then close >> wirehark The child window will remain and show a portion of the main >> window on Windows. >> Anders >> -----Original Message----- >> From: wireshark-dev-bounces@xxxxxxxxxxxxx >> [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of RUOFF LARS >> Sent: den 14 oktober 2009 11:34 >> To: Developer support list for Wireshark >> Subject: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour >> >> Coming back on this subject... >> >> @Jeff: >> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2421 >> => This ss definitevly the same issue. >> >> All child dialogs are affected because all use the same function to >> open: >> The problem is the line in gtk/dlg_utils.c: >> In function dlg_window_new(const gchar *title): >> gtk_window_set_transient_for(GTK_WINDOW(win), >> GTK_WINDOW(top_level)); >> >> Here all dialogs are made transient to the main window. >> The info on this function >> (http://developer.gimp.org/api/2.0/gtk/GtkWindow.html#gtk-wind >> ow-set-tra >> nsient-for) >> suggests that it is good practice to to so for all child dialogs, but >> the behaviour on Windows is unbearable! >> When *not* called, the behaviour on Windows is: All dialogs will have >> their own taskbar tab (grouped/ungrouped depends on your Windows >> settings of course), and simple click on any open window space brings >> the window to front. I'm unhappy with the fact that taskbar space is >> cluttered up by child windows, but I still prefer this behaviour to >> the current one, which is a pain for me. >> >> Is there any particular reason we need to have the windows transient >> to top level? >> What's the behaviour on Linux/Mac/...? >> If no consensus can be achieved, may I suggest for a preference >> setting? >> >> Lars >> >> >> >>> -----Original Message----- >>> From: wireshark-dev-bounces@xxxxxxxxxxxxx >>> [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of >> Jeff Morriss >>> Sent: mercredi 16 septembre 2009 19:30 >>> To: Developer support list for Wireshark >>> Subject: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour >>> >>> RUOFF LARS wrote: >>>> Hi, >>>> >>>> i don't know what has been changed exactly, but the VoIP >> Calls and >>>> -Graph dialog behaviour seems totally screwed up on 1.2.2 >>> on Windows. >>>> Initial condition: Wireshark main window maximized. >>>> Once the Voip Calls and -Graph dialogs are opened: >>>> Click on a line in the Graph dialog. >>>> Now try to navigate to the packet details in main window. >>>> Clicking on the main window doesn't bring it to front. >>>> So minimize the Graph window => minimizes ALL windows! >>>> So it needs an additional step to maximize the main window again. >>>> Navigating back to the Graph dialog is a matter of luck: >>>> Either you clicked on the right one of the two dialog >>> handles that are >>>> shown in minimized state ... or not. If you clicked on the >>> wrong on, >>>> you're back to Calls dialog and need first to click on the >>> dialog to >>>> focus it and then on the Graph dialog to bring it to front. >>>> A nightmare! >>> >>> This bug sounds similar: >>> >>> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2421 ________________________________________________________________________ ___ Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
- Follow-Ups:
- Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- From: Jaap Keuter
- Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- References:
- Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- From: RUOFF LARS
- Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- From: Anders Broman
- Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- From: RUOFF LARS
- Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- From: Anders Broman
- Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- From: Jaap Keuter
- Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- Prev by Date: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-ppc
- Next by Date: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- Previous by thread: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- Next by thread: Re: [Wireshark-dev] VoIP Calls and -Graph dialog behaviour
- Index(es):
- Get Wireshark
- Download
- Code of Conduct