Wireshark-dev: Re: [Wireshark-dev] buildbot failure in Wireshark (development) on Solaris-10-SP
From: "Anders Broman" <[email protected]>
Date: Thu, 20 Aug 2009 08:05:42 +0200
-----Ursprungligt meddelande-----
Från: [email protected]
[mailto:[email protected]] För didier
Skickat: den 20 augusti 2009 00:48
Till: Developer support list for Wireshark
Ämne: Re: [Wireshark-dev] buildbot failure in Wireshark (development) on
Solaris-10-SPARC

Hi,
Le mercredi 19 août 2009 à 13:55 -0700, Guy Harris a écrit :
>> On Aug 19, 2009, at 1:28 PM, [email protected] wrote:
>> 
>> > The Buildbot has detected a new failure of Solaris-10-SPARC on  
>> > Wireshark (development).
>> > Full details are available at:
>> >
http://buildbot.wireshark.org/trunk/builders/Solaris-10-SPARC/builds/2219
>> >
>> > Buildbot URL: http://buildbot.wireshark.org/trunk/
>> >
>> > Buildslave for this Build: solaris-10-sparc
>> >
>> > Build Reason:
>> > Build Source Stamp: HEAD
>> > Blamelist: etxrab
>> >
>> > BUILD FAILED: failed compile
>> 
>> g_string_chunk_clear() is documented as being "Since 2.14"; should we  
>> find another way of freeing the strings (would freeing the entire  
>> string chunk, allocating a new chunk, and setting the pointer in  
>> question to point to the new chunk work),
>Yest it should work.
>
>But there's a least another problem in 
>gtk/expert_dlg.c:expert_dlg_packet()
>the useless line.
>
>
> ei->protocol = ei->protocol;
>
>In my version it works because I also changed epan/expert.c
>expert_set_info_vformat()
>ei->protocol    = ep_strdup(pinfo->current_proto);
>to 
>ei->protocol    = pinfo->current_proto;
>
>because pinfo->current_proto is currently always a constant but it's not
>something we can enforce. Maybe it should use a string_chunk too.
>
>Didier

Is there any advantage in expert dialog that's not in expert dialog
composite? If not perhaps it's time to go for expert_dlg_cmp and remove
expert dialog.
Expert dialog is using deprecated GTK functions.
Regards
Anders

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:[email protected]?subject=unsubscribe