ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-dev: Re: [Wireshark-dev] use "else" instead of "ifndef _WIN32"

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Sun, 11 Jan 2009 19:17:11 +0100
Committed revision 27212.

Toralf F�rster wrote:
Hi,

I'm wondering, why within dumpcap the ifdef _WIN32 is handle in 2 different ways within the same source file or - OTOH - should the patch below be applied ? :

tfoerste@n22 ~/devel/wireshark $ svn diff --diff-cmd diff dumpcap.c
Index: dumpcap.c
===================================================================
--- dumpcap.c   (revision 27209)
+++ dumpcap.c   (working copy)
@@ -2332,10 +2332,9 @@

 #ifdef _WIN32
   WSADATA              wsaData;
-#endif  /* _WIN32 */
-#ifndef _WIN32
+#else
   struct sigaction action, oldaction;
-#endif
+#endif  /* _WIN32 */

   gboolean             start_capture = TRUE;
   gboolean             stats_known;