Wireshark · Wireshark-dev: [Wireshark-dev] problems with comment for epan/packet-windows-common.c:dissect_nt_sid

[yami <yamisoe@xxxxxxxxx>]

Hi dev,

There're two issues with comment for dissect_nt_sid:

1. sid_str should NOT be freed by the caller, since it is allocated by ep_alloc (called by ep_strdup_printf or ep_strdup). So the comment is wrong?
2. since dissect_nt_sid is external, should this comment be moved to header file?


Thanks!