Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 25612: /trunk/epan/dissectors/ /trun
From: "Abhik Sarkar" <[email protected]>
Date: Fri, 27 Jun 2008 11:39:35 +0400
Hi Joerg,

Actually, I discovered the problem when (by mistake) I captured the
trace without the "-s 0" option passed to tcpdump. So, actually a
large part of the MSU has already been lost. There is no way of
knowing what the next nibble was in the original packet, so adding a 0
in the end would actually produce an incorrect last byte (and the MSU
would still be incomplete), but removing the last nibble at least
ensures that whatever is passed to the MTP3 dissector (even though
incomplete) is what was received.

So, I think Jeff's approach is OK.

Best regards,
Abhik.

On Fri, Jun 27, 2008 at 2:40 AM, Joerg Mayer <[email protected]> wrote:
> On Thu, Jun 26, 2008 at 08:40:33PM +0000, [email protected] wrote:
>>  From me: Check if that will happen and chop off the nibble before giving it to
>>  convert_string_to_hex() so we'll dissect as much of the MSU as possible.
>
> Wouldn't it be more helpful to add a 0, that way no information would be lost.
>
>  ciao
>    Joerg
> --
> Joerg Mayer                                           <[email protected]>
> We are stuck with technology when what we really want is just stuff that
> works. Some say that should read Microsoft instead of technology.
> _______________________________________________
> Wireshark-dev mailing list
> [email protected]
> https://wireshark.org/mailman/listinfo/wireshark-dev
>