Wireshark-dev: Re: [Wireshark-dev] need help : NSIS
From: Ulf Lamping <[email protected]>
Date: Sat, 23 Feb 2008 21:02:46 +0100
Pascal Heude schrieb:
Hi,

I am using MSVC2005. For that, I changed the comment in the section ##### Microsoft Visual C / Studio Variant #####
# "Microsoft Visual Studio 2005"
# Visual C++ 8.0, _MSC_VER 1400, msvcr80.dll
MSVC_VARIANT=MSVC2005

I have the following dll in the directory $(PROGRAM_FILES)\Microsoft Visual Studio 8\VC\redist\x86\Microsoft.VC80.CRT\*.* :
    - msvcm80.dll
    - msvcp80.dll
    - msvcr80.dll

I have one remark about the variable PROGRAM_FILES. I'm currently using a windows vista enterprise x64 bits. With this OS, there are differents "program files" directory which are not correctly handled by the wireshark environment/setup :
"not correctly handled" is a hard word. The script just expects stuff to be installed in the default PROGRAM_FILES location. I don't see a good solution to this, as you can easily mix 32 and 64 bit versions of programs here - so I don't see a good way to find the right location with a script.
    - C:\Program Files (x86)
    - C:\Program Files
Some programs are installed under the first directory, and others are installed under the second one. So, I had to check in which directory where programs were installed and to correct the scripts/makefiles.
That explains your problems here. So unless someone comes up with a good solution to handle the x64 systems, we might have to live with this problem.
BTW: Using vcredist also has it's problems, namely getting an ugly 
Microsoft dialog while installing Wireshark ...
Regards, ULFL
Regards.

Pascal

Ulf Lamping a écrit :
Hi!

Right, you are describing how you tried to fix it (which is not the intended way it should work), and I (as the author) try to find the cause of the problem.
Some questions:
Do you use MSVC 2005 "retail version" or MSVC 2005 "express edition" or something else ?
Which setting in config.nmake are you using for MSVC_VARIANT ?
Which dlls are in $(PROGRAM_FILES)\Microsoft Visual Studio 8\VC\redist\x86\Microsoft.VC80.CRT\*.* ? $(PROGRAM_FILES) is usually c:\Program Files\, but that depends on your personal setup.
Regards, ULFL


Pascal Heude schrieb:
Hi,
I'm not sure we understand each other. Here after is the file before the modification (the WAS) :
!ELSEIF "$(MSVC_VARIANT)" == "MSVC2005"
MSVCR_DLL=$(PROGRAM_FILES)\Microsoft Visual Studio 8\VC\redist\x86\Microsoft.VC80.CRT\*.*
Here after is the file after the modification (the IS) :
!ELSEIF "$(MSVC_VARIANT)" == "MSVC2005"
#MSVCR_DLL=$(PROGRAM_FILES)\Microsoft Visual Studio 8\VC\redist\x86\Microsoft.VC80.CRT\*.*
VCREDIST_EXE=$(WIRESHARK_LIBS)\vcredist_x86.exe

Regards.

Pascal

Ulf Lamping a écrit :
Pascal Heude schrieb:
Hi,

I had the same problem than bijjou200 and I found the following solution :

- edit the config.nmake file (the one in the installation directory of wireshark)
- copy the following line
VCREDIST_EXE=$(WIRESHARK_LIBS)\vcredist_x86.exe
between the following 2 lines (in the section "C-Runtime Redistributable"
!ELSEIF "$(MSVC_VARIANT)" == "MSVC2005"
and
MSVCR_DLL=$(PROGRAM_FILES)\Microsoft Visual Studio 8\VC\redist\x86\Microsoft.VC80.CRT\*.*
- finally put in comment the line (the previous one)
MSVCR_DLL=$(PROGRAM_FILES)\Microsoft Visual Studio 8\VC\redist\x86\Microsoft.VC80.CRT\*.*
I have choosen to modify the part "MSVC2005" of the section "C-Runtime 
Redistributable" because I am currently using this compiler. If you 
get the same problem with another compiler, you should choose the part 
according to your compiler.
    
        
Hmmm, are you sure, you've just simply set the MSVC_VARIANT setting wrong?!?

There is a difference between:

MSVC_VARIANT=MSVC2005

and

MSVC_VARIANT=MSVC2005EE


When I'm using the MSVC2005 setting on my Express Edition environment, I'm getting exactly the same error as described.
Regards, ULFL

P.S: I've added a message to the NSIS script output, "if the following is getting wrong, check MSVC_VARIANT" to avoid problems in the future.
_______________________________________________
Wireshark-dev mailing list
[email protected]
http://www.wireshark.org/mailman/listinfo/wireshark-dev
------------------------------------------------------------------------
Téléchargez gratuitement Messenger 2008 <http://www.windowslive.fr/majmessenger.asp>
------------------------------------------------------------------------

_______________________________________________
Wireshark-dev mailing list
[email protected]
http://www.wireshark.org/mailman/listinfo/wireshark-dev
_______________________________________________
Wireshark-dev mailing list
[email protected]
http://www.wireshark.org/mailman/listinfo/wireshark-dev

------------------------------------------------------------------------
Téléchargez gratuitement Messenger 2008 <http://www.windowslive.fr/majmessenger.asp>
------------------------------------------------------------------------

_______________________________________________
Wireshark-dev mailing list
[email protected]
http://www.wireshark.org/mailman/listinfo/wireshark-dev