Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 23873: /trunk/gtk/ /trunk/gtk/: menu

From: Stig Bjørlykke <stig.bjorlykke@xxxxxxxxx>
Date: Sun, 16 Dec 2007 23:02:56 +0100
On 15. des.. 2007, at 14.26, jake@xxxxxxxxxxxxx wrote:

With increasing number of dissectors, heuristics cause sometimes false hits on packets. It's a pain to go through the menu / enabled protocols dialog to temporarily disable such dissector. This change adds an option to the packet detail menu to do a point-and-click style temporary disable of such protocol.


This patch leads to a crash in several cases.

+  if (hfinfo->parent == -1)
+    id = proto_get_id((protocol_t *)hfinfo->strings);

The hfinfo->strings contains a protocol_t when handling a FT_PROTOCOL, but hfinfo->parent can be -1 in other cases. I suppose all elements created with proto_tree_add_text, which uses the static hf entry in proto.c, will crash wireshark when selected in the Protocol Details.


--
Stig Bjørlykke