Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 23560: /trunk/ /trunk/doc/: wireshar
From: Stig Bjørlykke <[email protected]>
Date: Sun, 25 Nov 2007 01:00:24 +0100
On 24. nov.. 2007, at 12.38, [email protected] wrote:

Log:
This patch adds (ten) temporary coloring rules which will only live until Wireshark is
quit. Temporary coloring filters can be set by:
Nice feature, I really like it :)

But when I reset the coloring I often get a crash. Like pressing <ctrl>-<space> several times. Not always, and very non deterministic. Uninitialized value somewhere?
(gdb) where
#0  0x00af9e3e in g_strdup ()
#1  0x0253ca0e in string_fvalue_set ()
#2 0x025059ea in proto_tree_set_string (fi=<value temporarily unavailable, due to optimizations>, value=<value temporarily unavailable, due to optimizations>) at proto.c:2151 #3 0x0250871b in proto_tree_add_string (tree=0x50d2660, hfindex=84753456, tvb=0x86a5d28, start=0, length=0, value=0x1 <Address 0x1 out of bounds>) at proto.c:2049
#4  0x02716ada in dissect_frame () at ctype.h:175
#5 0x024faec4 in call_dissector_through_handle (handle=0x6d0c9a0, tvb=0x86a5d28, pinfo=0x923c6b8, tree=0x50d2810) at packet.c:396 #6 0x024fb573 in call_dissector_work (handle=0x6d0c9a0, tvb=0x86a5d28, pinfo_arg=0x6d0c9a0, tree=0x50d2810) at packet.c:485 #7 0x024fcd95 in call_dissector (handle=0x6d0c9a0, tvb=0x86a5d28, pinfo=0x923c6b8, tree=0x50d2810) at packet.c:1774 #8 0x024fd2f0 in dissect_packet (edt=0x923c6b0, pseudo_header=0x0, pd=0x139f28 "ÿÿÿÿÿÿ", fd=0x863f328, cinfo=0x0) at packet.c:332
#9  0x00011844 in cf_select_packet (cf=0x139e20, row=0) at file.c:3253
#10 0x0005f2b5 in packet_list_select_cb (w=0x8641008, row=0, col=-1, evt=0x0) at packet_list.c:284
#11 0x00a6c21a in g_closure_invoke ()
#12 0x00a83277 in signal_emit_unlocked_R ()
#13 0x00a82311 in g_signal_emit_valist ()
#14 0x00503b98 in gtk_signal_emit ()
#15 0x003eb6ef in real_insert_row ()
#16 0x003e5a75 in gtk_clist_append ()
#17 0x000602ef in packet_list_append (text=0x0, data=0x0) at packet_list.c:796 #18 0x0000ea0f in add_packet_to_packet_list (fdata=0x85da650, cf=0x139e20, dfcode=0x0, pseudo_header=0x0, buf=0x0, refilter=0) at file.c:1011 #19 0x00011bdb in rescan_packets (cf=0x139e20, action=0xd9f35 "Colorizing", action_item=0xd9bb6 "all packets", refilter=0, redissect=0) at file.c:1612
#20 0x000120d0 in cf_colorize_packets (cf=0x0) at file.c:1411
#21 0x0048d3db in gtk_item_factory_callback_marshal ()
#22 0x00a83e94 in g_cclosure_marshal_VOID__VOID ()
#23 0x00a6c21a in g_closure_invoke ()
#24 0x00a83277 in signal_emit_unlocked_R ()
#25 0x00a82311 in g_signal_emit_valist ()
#26 0x00a82664 in g_signal_emit ()
#27 0x005e1a59 in gtk_widget_activate ()
#28 0x004be697 in gtk_menu_shell_activate_item ()
#29 0x004bebdf in gtk_menu_shell_button_release ()
#30 0x004ab0a7 in _gtk_marshal_BOOLEAN__BOXED ()
#31 0x00a6c51d in g_type_class_meta_marshal ()
#32 0x00a6c21a in g_closure_invoke ()
#33 0x00a834ed in signal_emit_unlocked_R ()
#34 0x00a823a3 in g_signal_emit_valist ()
#35 0x00a82664 in g_signal_emit ()
#36 0x005dce2f in gtk_widget_event_internal ()
#37 0x004a89ab in gtk_propagate_event ()
#38 0x004a93a5 in gtk_main_do_event ()
#39 0x0028c125 in gdk_event_dispatch ()
#40 0x00addeae in g_main_dispatch ()
#41 0x00adf424 in g_main_context_dispatch ()
#42 0x00adf9ae in g_main_context_iterate ()
#43 0x00ae01a3 in g_main_loop_run ()
#44 0x004a8d58 in gtk_main ()
#45 0x0005999f in main (argc=0, argv=0xbffffa54) at main.c:3097


- pressing <ctrl>-<digit> will create a conversation coloring filter based on the addresses of the currently selected packet (order TCP/UDP/IP/ Ethernet) This can also be achieved from the "View|Colorize Conversation" menu.
I know it's not easy to find good key combinations, but on OSX 10.5  
<ctrl>-<digit> is used to switch between Spaces.

--
Stig Bjørlykke