Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 23421: /trunk/ /trunk/gtk/: color_dl
From: Sake Blok <[email protected]>
Date: Sat, 10 Nov 2007 21:32:36 +0100
On Sat, Nov 10, 2007 at 09:04:12PM +0100, Sake Blok wrote:
> On Sat, Nov 10, 2007 at 08:06:34PM +0100, Stig Bj?rlykke wrote:
> >
> > What about using a Status column, like we have in the "Enabled  
> > Protocols"?
> > Much easier to turn on and off without having to select the rule before
> > hitting enable or disable.  And we get a more uniform way to enable/ 
> > disable
> > elements in lists :)
> At the moment it is not possible to enable/disable a block of protocols
> at the same time. This is not much of a problem because they are not
> grouped logically. Coloring rules can be grouped logically and therefore
> it is nice to be able to enable/disable a block at once.
> I do like the idea of uniformity though, so if it is possible to
> have a selection of multiple rows and it is possible to show the
> filter-colors in the list, just as is done now, I like the idea.
> I need to look into this, as I'm not a very experienced GTK coder...

I took a look at all the currently used list-like windows. As the 
"coloring rules" window enables the user to create entries, just like
the "Display filter macro", "capture filters" and "display filters"
window, it should resemble them more then it should resemble the
protocol list, which only uses a sorted list of non-user editable
items that can be enabled or disabled.

So for now, I'll stick to this layout, but of course some general
layout of all windows is still an neat idea. But a little over my
head to be honest :-)