Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 23421: /trunk/ /trunk/gtk/: color_dl
From: Sake Blok <[email protected]>
Date: Sat, 10 Nov 2007 21:04:12 +0100
> On 10. nov.. 2007, at 18.34, Stephen Fisher wrote:
> 
> > Nice feature.  Any chance you could enhance it so the enable button is
> > only active if the rule selected is disabled and the disable button is
> > only active if the rule selected is enabled?

Glad you likes :-)

I thought of that too until I realised that you can select multiple
rows at once. What happens when one of them is enabled and the others
are disabled?

This can of course be handled by going through the selection and do
the following:

- grey out both buttons when no rule is selected
- grey out the enable button when *all* selected rules are enabled
- grey out the disable button when *all* selected rules are disabled
- leave both buttons active if there is a mix of disabled and enabled
  rules

How does that sound?



On Sat, Nov 10, 2007 at 08:06:34PM +0100, Stig Bj?rlykke wrote:
>
> What about using a Status column, like we have in the "Enabled  
> Protocols"?
> Much easier to turn on and off without having to select the rule before
> hitting enable or disable.  And we get a more uniform way to enable/ 
> disable
> elements in lists :)

At the moment it is not possible to enable/disable a block of protocols
at the same time. This is not much of a problem because they are not
grouped logically. Coloring rules can be grouped logically and therefore
it is nice to be able to enable/disable a block at once.

I do like the idea of uniformity though, so if it is possible to
have a selection of multiple rows and it is possible to show the
filter-colors in the list, just as is done now, I like the idea.

I need to look into this, as I'm not a very experienced GTK coder...

Thank you both for your feedback :-)


Sake