Wireshark-dev: Re: [Wireshark-dev] Adding CFM plugin and requesting review.
From: "ronnie sahlberg" <[email protected]>
Date: Thu, 11 Oct 2007 11:59:40 +1000
some comments

1, the libfile should be a header file   packet-cmf.h with the usual
boilerplates included

2, all value strings must be terminated with a {0,NULL} entry or else
you risk reading beyond the end of the array.

3, get rid of the    if (proto_cfm == -1) {
  this function should only be called once anyway

On 10/11/07, keith mercer <[email protected]> wrote:
> I have opened the following bugzilla:
> http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1905
> Hopefully I have done it correctly, and have provided the needed material as
> this is the first time I have ever done this. :)
> This plugin will enable the dissection of CFM EOM ethernet packets defined
> by IEEE 802.1ag/D8.1 and also recognizes the opcodes defined by the ITU
> recommendations in Y.1731 as well as dissect AIS PDUs.  I plan on adding
> everything defined in Y.1731 in a future once I am sure I am heading down
> the right road with the current version of the code.
> Thanks to Anders Broman for fixing up the etypes.h and packet-ethertype.c so
> the ethertype does not come up as 'unknown'. ;)
> --Keith Mercer
>  ________________________________
> Ask a question on any topic and get answers from real people. Go to Yahoo!
> Answers.
> _______________________________________________
> Wireshark-dev mailing list
> [email protected]
> http://www.wireshark.org/mailman/listinfo/wireshark-dev