Wireshark-dev: Re: [Wireshark-dev] New dissector for TPNCP protocol
From: Valery Sigalov <[email protected]>
Date: Mon, 8 Oct 2007 09:26:09 +0200
Hello,
I am still waiting for feedback regarding this patch. Was it forgotten?

Thank you,
Valery.



-----Original Message-----
From: Valery Sigalov
Sent: Saturday, September 29, 2007 8:26 PM
To: 'Developer support list for Wireshark'
Subject: RE: [Wireshark-dev] New dissector for TPNCP protocol
Importance: High

Hello,
Could you please update me with the status of this patch? Is someone looking at it?

Thank you,
Valery.

-----Original Message-----
From: Valery Sigalov
Sent: Sunday, September 23, 2007 11:50 AM
To: 'Developer support list for Wireshark'
Subject: RE: [Wireshark-dev] New dissector for TPNCP protocol

Hello,
Thank you for reply!

I have already opened a ticket:
Bug 1853: new dissector for TPNCP protocol
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1853

I tried to follow all instructions, but please write me if I missed something.

Today I added also tpncp.dat file to be included in Wireshark project.

I like your idea about the distribution of this file with Wireshark and placing the more recent version on TPNCP Wiki page. Moreover it can be also distributed with AudioCodes' SW package and updated in every release of Wireshark.

I was not sure about the place of this file, so meanwhile I left it in plugins folder, but it can be easily replaced to some configuration directory by your choice.

As for license, it is no problem adding copyright header, but no Wireshark configuration file has it, so I was not sure if it is really needed here. Please advice.

Thank you,
Valery.


-----Original Message-----
From: [email protected]xxxxxxxxx [mailto:[email protected]] On Behalf Of Richard van der Hoff
Sent: Thursday, September 20, 2007 4:41 PM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] New dissector for TPNCP protocol

Hi Valery,

Valery Sigalov wrote:
> Hello,
>
> I am still waiting for feedback on my submit request. May be the better and proper way is including it in CVN repository?

First of all, thank you for releasing this dissector, writing up the
wiki pages, submitting the sample captures, etc. A lot of companies
wouldn't release a dissector for their proprietary protocol - so the
contribution is much appreciated.

However, like Jaap, the external tpncp.dat file worries me.

First of all, if you're happy for tpncp.dat to be distributed under the
GPL, please could it have a copyright header at the top of it saying so?

Secondly, I don't like the idea that someone has to download a file from
the wiki to make it work. We don't have a lot of control over what goes
on there, and this would effectively sanction whatever happened to be
there. What I think would be ok would be if the dissector worked fine
"out of the box", and the wiki said "if you want to dissect more recent
versions of the TPNCP protocol, download this file". I'd have thought
the configuration directory would make more sense than the plugins
directory, too.  The other maintainers may feel more strongly about
this, though... I must say it's not an ideal precedent to be setting.

Finally, please could you follow the advice in the developer's guide for
submitting changes
(http://www.wireshark.org/docs/wsdg_html/#ChSrcContribute) and submit a
complete patch to bugzilla.

Thanks,

Richard
_______________________________________________
Wireshark-dev mailing list
[email protected]
http://www.wireshark.org/mailman/listinfo/wireshark-dev