Andrew Feren <acferen@xxxxxxxxx> has asked for review_for_checkin:
Bug 1606: Improve preferences for Netflow
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1606
------- Additional Comments from Andrew Feren <acferen@xxxxxxxxx>
Issue 1 : Memory management
Honestly, I'm not quite sure what was going on there either. I pillaged the
code from packet-tcap.c and didn't give much thought to it. I have removed the
superfluous range variables and it is still working fine. I guess they weren't
needed.
Issue 2 : comments
I wasn't sure what to add here. Hope my minimal comments are sufficient. Let
me know if more detail is needed.
Issue 3 : extract the common parts of proto_reg_handoff_netflow and
netflow_reinit
I should have done this initially. proto_reg_handoff_netflow now calls
netflow_reinit
