Wireshark-dev: Re: [Wireshark-dev] AMQP dissector patch
From: "Luis Ontanon" <[email protected]>
Date: Sun, 3 Jun 2007 21:33:05 +0200
You could use _U_ in the template for all those arguments that might
not be used, regardless of whether they're actually used or not. If
_U_ is not necessary there's no problem if it is present.

L

On 6/1/07, Martin Sustrik <[email protected]> wrote:
Steve,

The problem is that the code is generated from the protocol
specification. If I was to find out which parameters actually need _U_
and which do note, the code generation would get considerably more
complex (two passes instead of single one).

Martin

From: Stephen Fisher <[email protected]>
Date: Mon, 21 May 2007 14:02:33 -0700

On Mon, May 21, 2007 at 02:30:59PM +0200, Martin Sustrik wrote:

 > Here's the patch for following issues:
 >
 > - If there are several AMQP frames in single TCP packet, all of them are
 > shown in the 'info' column
 > - AMQP heartbeat is dissected correctly, it doesn't assert any more
 >
 > Can you please apply the patch to the SVN?

I have one question before applying the patch.  Both in your patch and
in the existing code, many functions have _U_ for every paramter in
functions, even when those variables are used within the function.  Any
idea why that is?


Steve

_______________________________________________
Wireshark-dev mailing list
[email protected]
http://www.wireshark.org/mailman/listinfo/wireshark-dev


--
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan