Wireshark-dev: Re: [Wireshark-dev] [PATCH] Fix IPMI Completion Codes
From: Flavio Leitner <[email protected]>
Date: Fri, 1 Jun 2007 14:49:53 -0300
On Tue, May 29, 2007 at 01:56:45PM -0700, Al Chu wrote:
> 1) I think you should move the original:
> 
>        /* added by lane */
>         { 0x81, "cannot execute command, SEL erase in progress" },
> 
> from ipmi_ccode_vals[] into a new array and add command specific error
> support into get_ccode_cmd_text(). 

See below.


> 2) I believe your patch works for this particular instance, b/c in 0x39
> is only used by the get session challenge command.  However (if you take
> a look in table 44-11), there are many "commands" that use the same hex
> "cmd" code.  (i.e. both get device id and get chassis status and get set
> lan configuration parameters use cmd == 0x01.)  So get_ccode_cmd_text()
> should key off both the cmd and the network function in order to
> determine which command specific error code string array to use.

You're right. Good point.

> 3)
> The coding requirements and semantics for wireshark are largely unknown
> to me, so I apologize if what I say below is faux pas for wireshark.
> 
> If a command specific error code is returned but doesn't have an command
> specific array of strings supported, it should instead say "Command
> Specific Error" instead of just "Unknown".

Sure, just return a message like "Command specific error not supported yet" 
in range 80-BEh by default if there is no implementation yet.

thanks,

-- 
Flávio