Guy Harris wrote:
Jeff Morriss wrote:
...
Should the PRI*64 macros (which I just recently started adding--meaning
there were some there before, it's just that only recently did /I/ add
some) be replaced with G_GINT64_MODIFIER?
Yes
I've done that.
(except for calls that use printf/fprintf/sprintf/snprintf rather
than the GLib equivalents, if any; there should be as few of those as
possible).
...although for TShark taps, which might print statistics to the
standard output, there's no g_printf() routine, so they use printf(),
which should still use the PRI*64 macros.
We should also update the documentation.
I've done that as well.
Note that any dissector generators that generate format strings should
be updated as well (I've updated idl2wrs's wireshark_gen.py helper
script; asn2wrs doesn't generate format strings, as far as I can tell; I
don't know what the PIDL generator does).
