Here is a patch for the documentation on the pop-up menus. Please note that the .diff file is from the top-level, even though it affects only one file.
As I understand it, changed binary (in this case PNG) files have to be submitted entire, as svn diff ignores them.
- Changed screenshots for pop-up menus over Packet List and Packet Details panes
- Added entries in tables for new menu items; followed the existing format of sub-menu/ Command used in Packet Bytes Pane
- Changed position of existing "Copy" entry in Packet Details pane to match screenshot (this had been moved prior to my changes)
- Expanded notes on Packet Bytes Pane "Copy/" commands (filled in parts marked XXX)
I've tested that these changes build under
make wsug.validated
make wsug_html_chunked
make wsug_html
I haven't been able to test the other formats.
Cheers
Doug
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx on behalf of Stephen Fisher
Sent: Mon 1/22/2007 1:09 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Thu, Jan 11, 2007 at 01:59:56PM -0000, Douglas Pratley wrote:
> This is a patch adding items to the context menus for the packet list
> and packet details panes for copying packet data to the clipboard.
Looking good so far. I fixed a few warnings about unused variables.
BTW, if you have a function call that takes a parameter that it doesn't
use you can put _U_ after it and Wireshark's compilation process will
expand that to code that tells (gcc at least) not to warn about that.
> I'm not convinced that Base64 is useful; I wanted to implement a
> non-trivial encoding to test a particular path through the code.
Instead of encoding the contents into base64, decoding a stream of
base64 data and placing the decoded data in the clipboard would be very
useful.
> I have not updated any documentation because I cannot find a
> description of what context menu items do anywhere (main menu items
> are listed in the man page). If I should have done, please let me
> know.
The documentation here needs to be updated with new screenshots and
text:
http://www.wireshark.org/docs/wsug_html_chunked/ChWorkDisplayPopUpSection.html
You can find this chapter in the source as
docbook/wsug_src/WSUG_chapter_work.xml.
Steve
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev
This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately.
Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies.
Detica Limited is registered in England under No: 1337451.
Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England.
<<winmail.dat>>
