Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] [PATCH] Add support for the CIPSO IPv4 option

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Fri, 19 Jan 2007 20:38:13 +0100 (CET)
Hi,

Have a look at the developer manual to see which libraries are used to
provide cross platform support. Some other functions are wrapped in an
application specific wrapper since normal libraries didn't provide
sufficient cross platform support. File handling comes to mind.

That's it.

Thanx,
Jaap

On Fri, 19 Jan 2007, Paul Moore wrote:

> On Friday, January 19 2007 12:36 pm, Jaap Keuter wrote:
> > You at the right spot here, but sometimes it's a bit busy that review of
> > patches gets delayed. A headsup is always oke.
> >
> > Few remarks on the patch.
> >
> > Please attach the patch to your emails i.s.o. pasting them in. It makes
> > handling patches so much easier.
> >
> > You've used some string handling glib functions which, to my knowledge,
> > aren't available in glib 1.2. Functions I've seen are g_stpcpy and
> > g_strlcat, but maybe there more. Can you verify this works on glib 1.2?
>
> Thanks for the response and the comments; I'll attach my patches instead of
> including them inline as before.
>
> Regarding the use of the glib string functions, I saw a bunch of glib
> functions being used in the sources instead of their standard C counterparts
> so I went to the glib website and used as many functions as I could out of
> their 2.0 API.  Guess I picked the wrong version.
>
> Personally, I guess I would prefer to just stick with the standard C functions
> as they are far more portable but I can understand the desire to use glib
> where possible.  What is the "official" stance on things like this?
>
> --
> paul moore
> linux security @ hp
>
>