Wireshark-dev: Re: [Wireshark-dev] [Patch] : IPsec
From: Jaap Keuter <[email protected]>
Date: Thu, 21 Dec 2006 23:18:26 +0100 (CET)
Hi,

Large patch, unfortunately it's mixed whitespace and code change.
Could you split these out, making them easier to review?

Thanx,
Jaap

On Wed, 20 Dec 2006, [ISO-8859-1] Fr?d?ric Roudaut wrote:

> Hi,
>
> This is a patch for the IPsec dissector in order to update/correct the
> following points:
>
> - Fixes for TWOFISH-CBC with keylen 128 bits.
> - Add CAST5-CBC
> - Add HMAC-RIPEMD160-96
> - Fixes for AES-CTR that was completely broken
> - Code Update : Encryption, Authentication are now in separated
> functions. It seems easier to add new algorithms. Just modify the ESP
> Context function and enhance the Encrypt or Authentication function
> according to the algorithm.
>  - The IV field is no more decrypted. (Instead it is set in the cipher
> object)
>  - the authentication field remains in the main tree that is not decrypted.
>
>
> Best Regards,
>
> ps: In attachment you will also get a dump with all the available
> algorithms for FuzzTesting. It also contains a packet (a tunnel of
> tunnel of ..) with all the different algorithms and a  Configure file
> to set  the  keys/algorithms.
> The packets have been generated using an Extension to Scapy I have done
> to handle IPsec.
> See http://roudaut.frederic.free.fr/data/scapysec/doc/scapysec.html if
> needed
>
> ---
> Frederic Roudaut
>
>
>