Wireshark-dev: Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profi
From: Stephen Fisher <[email protected]>
Date: Wed, 13 Dec 2006 16:16:29 -0800
On Wed, Dec 13, 2006 at 05:49:58PM +0100, Stig Bj?rlykke wrote:

> I have added a new dissector for DMP (STANAG 4406 Direct Message 
> Profile) as defined in STANAG 4406 Annex E.  The DMP protocol has no 
> assigned UDP port number yet, so the default value in this dissector 
> is 0 (I suppose this is som sort of "disabled"?) until we get this 
> registered.

Yes, port 0 is the way to leave a dissector unattached to a port.  This 
allows the user to specify a port in the preferences or to right click 
and choose decode as and pick the protocol in there.

> The dissector has been tested on OSX Intel/PowerPC and Solaris SPARC.

I tested it on FreeBSD / x86.

> Changes in this patch:
> * Added DMP dissector
> * Added a new CRC table and functions in crc16.c
> * Made NonDeliveryReasonCode and NonDeliveryDiagnosticCode available  
> from X.411
> * Made NonReceiptReasonField and DiscardReasonField available from X.420

I have committed the code updates as SVN revision 20133.

> * Fixed a typo in README.developer

I have committed the doc update as SVN revision 20132.

> Comments on the implementation are welcome :)

Great work; thanks for your contribution!  I changed the indentation 
from 2 spaces to tabs [intended to be 8 spaces wide] as that is the 
preferred method for new code.  Did you use Emacs to write the program?  
That and other programs let you change the default indentation logic.


Thanks,
  Steve