ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-dev: [Wireshark-dev] [PATCH] ISIS dissector

From: Sebastien Tandel <sebastien@xxxxxxxxx>
Date: Sun, 10 Dec 2006 04:06:15 +0100
Hi all,

   a little patch against revision 20088 in packet-isis-lsp.c for the
following :
- hf_isis_lsp_remaining_life declared but unused
- replacing a proto_tree_add_uint useless with proto_tree_add_item



thanx,

Sebastien Tandel
Index: epan/dissectors/packet-isis-lsp.c
===================================================================
--- epan/dissectors/packet-isis-lsp.c	(r�vision 20088)
+++ epan/dissectors/packet-isis-lsp.c	(copie de travail)
@@ -1769,9 +1769,8 @@
 	offset += 2;
 
 	if (tree) {
-		proto_tree_add_text(lsp_tree, tvb, offset, 2,
-                                    "Remaining Lifetime: %us",
-                                    tvb_get_ntohs(tvb, offset));
+		proto_tree_add_item(lsp_tree, hf_isis_lsp_remaining_life, 
+			tvb, offset, 2, FALSE);
 	}
 	offset += 2;
 	offset_checksum = offset;
@@ -1789,9 +1788,8 @@
 	offset += id_length + 2;
 
 	if (tree) {
-		proto_tree_add_uint(lsp_tree, hf_isis_lsp_sequence_number, tvb,
-			offset, 4,
-			tvb_get_ntohl(tvb, offset));
+		proto_tree_add_item(lsp_tree, hf_isis_lsp_sequence_number, 
+			tvb, offset, 4, FALSE);
 	}
 	if (check_col(pinfo->cinfo, COL_INFO)) {
 		col_append_fstr(pinfo->cinfo, COL_INFO, ", Sequence: 0x%08x, Lifetime: %5us",