Wireshark-dev: Re: [Wireshark-dev] [PATCH] range_string and OSPF bcmodelid
From: "Francesco Fondelli" <[email protected]>
Date: Wed, 6 Dec 2006 14:20:52 +0100
Hi,

On 12/5/06, Stephen Fisher <[email protected]> wrote:
On Mon, Dec 04, 2006 at 10:03:57AM +0100, Francesco Fondelli wrote:

> So I defined a range_string struct. It's like value_string
> but stores range <-> string pairs.
> Moreover I wrote rval_to_str(), match_strrval_idx()
> match_strrval() which are behaving exactly as
> val_to_str(), match_strval_idx() and match_strval().
> (almost cut && paste :-))

This sounds like a great idea - I could use it in the VNC dissector too.
thanks

Could you write up some documentation changes to doc/README.developer so
others will know how to use this feature.  You can send a diff of only
README.developer since we already have the other patches.  We will then
review it for inclusion in Wireshark.
You find it attached. My English sucks so check it out
more carefully than my code :-)

Thanks,
  Steve
thanks
Ciao
FF
Index: doc/README.developer
===================================================================
--- doc/README.developer	(revision 19892)
+++ doc/README.developer	(working copy)
@@ -1519,6 +1519,28 @@
 If the field has a numeric rather than an enumerated type, the 'strings'
 field would be set to NULL.
 
+If the field has a numeric type that might logically fit in ranges of values
+one can use a range_string struct.
+
+Thus a 'range_string' structure is a way to map ranges to strings.
+
+        typedef struct _range_string {
+                guint32        value_min;
+                guint32        value_max;
+                const gchar   *strptr;
+        } range_string;
+
+For fields of that type, you would declare an array of "range_string"s:
+
+	static const range_string rvalstringname[] = {
+		{ INTVAL_MIN1, INTVALMAX1, "Descriptive String 1" }, 
+		{ INTVAL_MIN2, INTVALMAX2, "Descriptive String 2" }, 
+		{ 0,           0,          NULL                   }
+	};
+
+If INTVAL_MIN equals INTVAL_MAX for a given entry the range_string 
+behavior collapses to the one of value_string. 
+
 FT_BOOLEANS have a default map of 0 = "False", 1 (or anything else) = "True".
 Sometimes it is useful to change the labels for boolean values (e.g.,
 to "Yes"/"No", "Fast"/"Slow", etc.).  For these mappings, a struct called
@@ -2303,7 +2325,33 @@
 them; this permits the results of up to three calls to 'val_to_str' to
 be passed as arguments to a routine using those strings.)
 
+1.7.2 match_strrval and rval_to_str.
 
+A dissector may need to convert a range of values to a string, using a
+'range_string' structure.
+
+'match_strrval()' will do that:
+
+	gchar*
+	match_strrval(guint32 val, const range_string *rs)
+
+It will look up the value 'val' in the 'range_string' table pointed to
+by 'rs', and return either the corresponding string, or NULL if the
+value could not be found in the table. Please note that its base
+behavior is inherited from match_strval().
+
+'rval_to_str()' can be used to generate a string for values not found in
+the table:
+
+	gchar*
+	rval_to_str(guint32 val, const range_string *rs, const char *fmt)
+
+If the value 'val' is found in the 'range_string' table pointed to by
+'rs', 'rval_to_str' will return the corresponding string; otherwise, it
+will use 'fmt' as an 'sprintf'-style format, with 'val' as an argument,
+to generate a string, and will return a pointer to that string. Please 
+note that its base behavior is inherited from match_strval().
+
 1.8 Calling Other Dissectors.
 
 As each dissector completes its portion of the protocol analysis, it