Wireshark-dev: Re: [Wireshark-dev] [PATCH] packet-mysql.c: Trivial change
From: Martin Warnes <[email protected]>
Date: Wed, 29 Nov 2006 18:35:50 +0000
Attached updated patch to use "dissect_mysql_pdu" instead of
"dissect_mysql" when registering the protocol dissector.

Regards .. Martin

Martin Warnes wrote the following on 29/11/2006 10:50:
> Obviously not so trivial as dissect_mysql does reassembly, so it looks
> like I shoud register dissect_mysql_pdu instead
>
> ... or would this only work if the higher level dissector also did
> reassembly which mine does?
>
>
>
> Martin Warnes wrote the following on 29/11/2006 09:37:
>   
>> Add register_dissector() call to allow being called as a subdissector
>>   
>> ------------------------------------------------------------------------
>>
>> Index: packet-mysql.c
>> ===================================================================
>> --- packet-mysql.c	(revision 20004)
>> +++ packet-mysql.c	(working copy)
>> @@ -901,6 +901,8 @@
>>  				       "Whether the MySQL dissector should reassemble MySQL buffers spanning multiple TCP segments."
>>  				       " To use this option, you must also enable \"Allow subdissectors to reassemble TCP streams\" in the TCP protocol settings.",
>>  				       &mysql_desegment);
>> +			       
>> +	register_dissector("mysql", dissect_mysql, proto_mysql);				       
>>  }
>>  
>>  
>>   
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Wireshark-dev mailing list
>> [email protected]
>> http://www.wireshark.org/mailman/listinfo/wireshark-dev
>>   
>>     
>
>
> ----------------------------------------------------------
> Scanned by ClamAV antivirus system - http://www.clamav.net
> Virus signatures last updated: Wed Nov 29 09:33:21 2006
> _______________________________________________
> Wireshark-dev mailing list
> [email protected]
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
> ��������������������������������������������jy�u�����U����2�צ�m�����rV�j��z�b��,�	ڶ�޲V���]jם�g�6���O����m4
>   

Index: packet-mysql.c
===================================================================
--- packet-mysql.c	(revision 20016)
+++ packet-mysql.c	(working copy)
@@ -901,6 +901,8 @@
 				       "Whether the MySQL dissector should reassemble MySQL buffers spanning multiple TCP segments."
 				       " To use this option, you must also enable \"Allow subdissectors to reassemble TCP streams\" in the TCP protocol settings.",
 				       &mysql_desegment);
+			       
+	register_dissector("mysql", dissect_mysql_pdu, proto_mysql);				       
 }