Wireshark-dev: Re: [Wireshark-dev] Q931 subaddress odd/even indicator fix
From: "Anders Broman" <[email protected]>
Date: Tue, 28 Nov 2006 07:32:04 +0100
Checked in.
BR
Anders

-----Ursprungligt meddelande-----
Från: [email protected]
[mailto:[email protected]] För Richard Braun
Skickat: den 27 november 2006 18:52
Till: [email protected]
Ämne: [Wireshark-dev] Q931 subaddress odd/even indicator fix

Hello,

The Q931 dissector applies a wrong mask when testing the odd/even indicator
bit. Here is a patch that fixes the issue.


2006-11-27  Richard Braun  <[email protected]>

	* epan/dissectors/packet-q931.c (q931_odd_even_indicator_vals):
	Fixed odd/even indicator mask.
	(dissect_q931_party_subaddr_ie): Likewise.

Index: epan/dissectors/packet-q931.c
===================================================================
--- epan/dissectors/packet-q931.c	(revision 20002)
+++ epan/dissectors/packet-q931.c	(working copy)
@@ -2157,7 +2157,7 @@
 
 static const value_string q931_odd_even_indicator_vals[] = {
 	{ 0x00, "Even number of address signals" },
-	{ 0x10, "Odd number of address signals" },
+	{ 0x08, "Odd number of address signals" },
 	{ 0,    NULL }
 };
 
@@ -2176,7 +2176,7 @@
 	      "Unknown (0x%02X)"));
 	proto_tree_add_text(tree, tvb, offset, 1,
 	    "Odd/even indicator: %s",
-	    val_to_str(octet & 0x10, q931_odd_even_indicator_vals,
+	    val_to_str(octet & 0x08, q931_odd_even_indicator_vals,
 	      "Unknown (0x%02X)"));
 	offset += 1;
 	len -= 1;


-- 
Richard Braun
Proformatique - 67 rue Voltaire - 92800 Puteaux
Tel. : 01 41 38 99 65 - Fax. : 01 41 38 99 70
Email : [email protected] - http://proformatique.com/

PS: I haven't subscribed to the mailing-list, please send any reply using
my address in Cc.