Wireshark-dev: Re: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars
From: Gerald Combs <[email protected]>
Date: Fri, 24 Nov 2006 22:22:01 -0800
Guy Harris wrote:
> Stefan (metze) Metzmacher wrote:
> 
>> if isprint() is used, we should make sure the value
>> isn't larger than 0xFF, as currently GDK_Up and GDK_Down
>> trigger a focus switch to the filter.
> 
> Should it be
> 
> 	if (isascii(event->keyval) && isprint(event->keyval))
> 
> so that control characters don't get intercepted, either?

Checked in.