Wireshark-dev: Re: [Wireshark-dev] ACN Source code
From: "Bill Florac" <[email protected]>
Date: Tue, 7 Nov 2006 04:14:11 -0600
Thanks for cleaning these up.. I should have caught the bitfields... I'm
not used to all the cross-platform problems (but I'm learning... :)

-----Original Message-----
From: [email protected]
[mailto:[email protected]] On Behalf Of Guy Harris
Sent: Tuesday, November 07, 2006 3:09 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] ACN Source code


Joerg Mayer wrote:

> Here is the list of warnings it creates on my system:

I've checked in some changes that should fix most, if not all, of them.

In particular:

> packet-acn.h:168: warning: type of bit-field 'dummy' is a GCC 
> extension
> packet-acn.h:169: warning: type of bit-field 'D' is a GCC extension
> packet-acn.h:170: warning: type of bit-field 'H' is a GCC extension
> packet-acn.h:171: warning: type of bit-field 'V' is a GCC extension
> packet-acn.h:172: warning: type of bit-field 'L' is a GCC extension

C bitfields are a Very Very Very Very Very Very Very Very Very Very Bad 
Idea when extracting bitfields from packet data, as the C language makes

*no* guarantee about the order of bitfields in a value.
_______________________________________________
Wireshark-dev mailing list
[email protected]
http://www.wireshark.org/mailman/listinfo/wireshark-dev