Hi,
Good to see the dissector is improving. A couple of _add_text() calls is
oke, but the more they can be avoided the better. Problem is twofold, one
being unable to filter on them, the other that the presentation of the
overall look and feel is implemented by the core itself. Changes in that
should be confined to there, not the dissector. Sure not all dissectors
use this method, but then again not all dissectors are created equal.
Thanx,
Jaap
On Sun, 22 Oct 2006, Tobias Erichsen wrote:
> Hi again,
>
> no problem. I have already started to move a good amount of the
> literals into the h-file and I will try to move all I can into
> "value_string" arrays.
>
> But this won't be possible for everything, as MIDI itself has
> some "specialities" already within the coding and RTP-MIDI takes
> this even one step further...
>
> So I won't get around the use of a couple of "add_text()" calls.
>
> Apart from that, I noticed quite a few other plugins to use the
> "add_text()" pretty regularly - so what's the reason not to use it?
>
> Tobias
>
> > -----Urspr??ngliche Nachricht-----
> > Von: wireshark-dev-bounces@xxxxxxxxxxxxx
> > [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] Im Auftrag von
> > Jaap Keuter
> > Gesendet: Sonntag, 22. Oktober 2006 12:35
> > An: Developer support list for Wireshark
> > Betreff: Re: [Wireshark-dev] Wireshark 0.99.4pre1 is now
> > available [heur]
> >
> > Hi,
> >
> > Sorry dude, since it's not yet picked up and we want no 'big'
> > changes now I vote against it. The reason why it was not
> > picked up? I don't know, but I would have to rework the code
> > considerable before committing it, as I would want to get rid
> > of the 10 level deep conditionals, the use of literals iso
> > constants and the use of add_text(). But that's just my preference.
> >
> > Thanx,
> > Jaap
> >
> > On Sat, 21 Oct 2006, Tobias Erichsen wrote:
> >
> > > Hi Gerald,
> > >
> > > how about including my RTP-MIDI dissector plugin in this
> > new version?
> > >
> > > Best regards,
> > > Tobias
> > >
> > > > -----Urspr????ngliche Nachricht-----
> > > > Von: wireshark-dev-bounces@xxxxxxxxxxxxx
> > > > [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] Im Auftrag
> > von Gerald
> > > > Combs
> > > > Gesendet: Samstag, 21. Oktober 2006 18:55
> > > > An: Wireshark announcements; Developer support list for
> > Wireshark;
> > > > Community support list for Wireshark
> > > > Betreff: [Wireshark-dev] Wireshark 0.99.4pre1 is now available
> > > > [heur]
> > > >
> > > > Wireshark 0.99.4pre1 is now available for testing.
> > Source code and
> > > > a Windows installer can be downloaded immediately from
> > > >
> > > > http://www.wireshark.org/download/prerelease/wireshark-0.99.4p
> > > > re1.tar.gz
> > > > http://www.wireshark.org/download/prerelease/wireshark-setup-0
> > > > .99.4pre1.exe
> > > >
> >
> > _______________________________________________
> > Wireshark-dev mailing list
> > Wireshark-dev@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> >
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
>
>
