hello,
the attached patch fix parsing of the setup header in the usb dissector.
Currently the size of the field specified into proto_tree_add_item call
was wrong.
Best regards,
Paolo
Index: epan/dissectors/packet-usb.c
===================================================================
--- epan/dissectors/packet-usb.c (revision 19501)
+++ epan/dissectors/packet-usb.c (working copy)
@@ -127,16 +127,16 @@
ti = proto_tree_add_protocol_format(parent, proto_usb, tvb, offset, sizeof(usb_setup_t), "URB setup");
setup_tree = proto_item_add_subtree(ti, usb_setup_hdr);
- proto_tree_add_item(setup_tree, hf_usb_request_type, tvb, offset, 4, FALSE);
- offset += 4;
- proto_tree_add_item(setup_tree, hf_usb_request, tvb, offset, 4, FALSE);
- offset += 4;
- proto_tree_add_item(setup_tree, hf_usb_value, tvb, offset, 4, FALSE);
- offset += 4;
- proto_tree_add_item(setup_tree, hf_usb_index, tvb, offset, 4, FALSE);
- offset += 4;
- proto_tree_add_item(setup_tree, hf_usb_length, tvb, offset, 4, FALSE);
- offset += 4;
+ proto_tree_add_item(setup_tree, hf_usb_request_type, tvb, offset, 1, FALSE);
+ offset += 1;
+ proto_tree_add_item(setup_tree, hf_usb_request, tvb, offset, 1, FALSE);
+ offset += 1;
+ proto_tree_add_item(setup_tree, hf_usb_value, tvb, offset, 2, FALSE);
+ offset += 2;
+ proto_tree_add_item(setup_tree, hf_usb_index, tvb, offset, 2, FALSE);
+ offset += 2;
+ proto_tree_add_item(setup_tree, hf_usb_length, tvb, offset, 2, FALSE);
+ offset += 2;
}
proto_tree_add_item(tree, hf_usb_data, tvb,
