ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-dev: Re: [Wireshark-dev] [PATCH] usb dissector

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Tue, 10 Oct 2006 11:04:59 -0700
Jaap Keuter wrote:

These includes won't work on my Debian box:
+#include <pcap/bpf.h>
+#include <pcap/usb.h>

Dependancy on pcap shouldn't be there. All is done via wiretap and if
these are needed for defines or header sizes, they'll have to be included
via #include <pcap.h>

Actually, they should be independently defined by the Wireshark dissector; that's what we do for the Linux cooked capture header.

It's not as if the header defined by <pcap/usb.h> is ever going to change - any change to the header would mean that you'd have two different header formats in files with the *same* magic number and the *same* DLT_ value, which means that *any* program reading those files would fail to correctly dissect some files.

I.e., the dissector shouldn't include <pcap.h>, <pcap/bpf.h>, or <pcap/usb.h>.