Wireshark-dev: Re: [Wireshark-dev] Loop in packet-q2931.c
From: Gerald Combs <[email protected]>
Date: Tue, 22 Aug 2006 09:51:22 -0500
Checked in.  Thanks!

[email protected] wrote:
>       Hello,
> 
> 
> I found a loop in the q2931 dissector, whereas I was dissecting Ranap
> Traces with a bad wireshark configuration.
> Wireshark did crash, after eating all the memory.
> 
> Here is a small patch to solve this issue
> <<
> svn diff epan/dissectors/packet-q2931.c
> Index: epan/dissectors/packet-q2931.c
> ===================================================================
> --- epan/dissectors/packet-q2931.c      (revision 18965)
> +++ epan/dissectors/packet-q2931.c      (working copy)
> @@ -1556,6 +1556,7 @@
>         while (len >= 3) {
>                 identifier = tvb_get_guint8(tvb, offset);
>                 value = tvb_get_ntohs(tvb, offset + 1);
> +               len -=3;
>                 switch (identifier) {
> 
>                 case 0x01:      /* Cumulative transit delay identifier */
> 
> 
> (See attached file: packet-q2931.c.diff.gz)
> 
> Regards
> Florent
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Wireshark-dev mailing list
> [email protected]
> http://www.wireshark.org/mailman/listinfo/wireshark-dev