Wireshark-dev: Re: [Wireshark-dev] Small [Patch] to H.323 VoIP calls
From: "Martin Mathieson" <[email protected]>
Date: Fri, 28 Jul 2006 00:44:59 +0100
Thanks for the capture, Keith.  The problem was with h450 hf fields that
weren't initialised sucessfully (at all in one case, or with non-unique
filter strings in several others) - it was hitting an assertion in proto.c
when an attempt was made to use those fields.

I was able to test by editing packet-h450.c directly, I couldn't regenerate
it from packet-h450-template.c.  I'm attaching a patch to
packet-h450-template.c that hopefully does the same thing.  If someone can
generate and check it packet-h450.c in for me I'll retest.

Thanks,
Martin

> If you could send a capture showing the problem  to the list (or directly
to
> me if you'd prefer), I'll take a look.
> Martin
>
> ----- Original Message ----- 
> From: "Keith French" <[email protected]>
> To: "Developer support list for Wireshark" <[email protected]>
> Sent: 25 July 2006 21:48
> Subject: Re: [Wireshark-dev] Small [Patch] to H.323 VoIP calls
>
>
> > Guys,
> >
> > Thanks for your efforts, as I am not a developer, I await 0.99.3 with
> > interest.
> >
> >
> > Keith French.
> >
> > ----- Original Message ----- 
> > From: "Martin Mathieson" <[email protected]>
> > To: "Developer support list for Wireshark" <[email protected]>
> > Sent: Tuesday, July 25, 2006 10:47 AM
> > Subject: Re: [Wireshark-dev] Small [Patch] to H.323 VoIP calls
> >
> >
> > > Thanks,  it looks like this should also fix part of the problem
reported
> > > in bug 1012 ("H225 Dissector Bug & VoIP Calls graph not OK").  My
trace
> > > had no decoding errors.
> > >
> > > Martin
> > >
> > >
> > > Jaap Keuter wrote:
> > >
> > >>Hi,
> > >>
> > >>Checked in.
> > >>
> > >>Thanx,
> > >>Jaap
> > >>
> > >>On Mon, 24 Jul 2006, Martin Mathieson wrote:
> > >>
> > >>
> > >>
> > >>>Hi,
> > >>>
> > >>>I'm not sure if this will help with the problems that Keith French is
> > >>>seeing, but when I loaded some of my old H.323 traces, one of them
> would
> > >>>assert/abort.  This patch fixes that assertion (looks like it was
> > >>>obviously
> > >>>asserting on the wrong pointer variable).
> > >>>
> > >>>Regards,
> > >>>Martin
> > >>>
> > >>>
> > >>>
> > >>
> > >>_______________________________________________
> > >>Wireshark-dev mailing list
> > >>[email protected]
> > >>http://www.wireshark.org/mailman/listinfo/wireshark-dev
> > >>
> > >>
> > >>
> > >
> > > _______________________________________________
> > > Wireshark-dev mailing list
> > > [email protected]
> > > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> > >
> > >
> > > -- 
> > > No virus found in this incoming message.
> > > Checked by AVG Free Edition.
> > > Version: 7.1.394 / Virus Database: 268.10.4/399 - Release Date:
> 25/07/2006
> > >
> > >
> >
> >
> >
> > -- 
> > No virus found in this outgoing message.
> > Checked by AVG Free Edition.
> > Version: 7.1.394 / Virus Database: 268.10.4/399 - Release Date:
25/07/2006
> >
> > _______________________________________________
> > Wireshark-dev mailing list
> > [email protected]
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
>
> _______________________________________________
> Wireshark-dev mailing list
> [email protected]
> http://www.wireshark.org/mailman/listinfo/wireshark-dev

Attachment: packet-h450-template.c.diff
Description: Binary data