Wireshark-dev: Re: [Wireshark-dev] [Patch] to MSRP dissector
From: Joerg Mayer <[email protected]>
Date: Wed, 19 Jul 2006 15:17:12 +0200
On Wed, Jul 19, 2006 at 11:52:43AM +0100, Martin Mathieson wrote:
> This patch:
> - adds headers found in later versions of the msrp drafts
> - fixes a problem where wrong length values were used while parsing the 
> request/status line and it was going beyond linelen
> - "Transaktion" -> "Transaction"
> - status code now appears as a numerical field
> - removes unused parameters from check_msrp_header()
> - tidies up some indentation
> It has survived some fuzz-testing.
> 
> Does anyone have a capture file that includes SDP setup traffic?  If I 
> can see it I'll add setting up of the MSRP conversation.

Hmm, I'm wondering about the following piece of code:

+       while (tvb_offset_exists(tvb, offset)) {
+               tvb_find_line_end(tvb, offset, -1, &next_offset, FALSE);
+                                 linelen = next_offset - offset;
...
+               offset = next_offset;
+       }
+}

if tvb_find_line_end returns -1, then next_offset will not be modified,
so if the first run returns a valid value and a later iteration fails,
then this loop might run endless? (Just reading code and docs, no
personal experience with this function).

 Ciao
     Joerg

-- 
Joerg Mayer                                           <[email protected]>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.