Wireshark-dev: Re: [Wireshark-dev] New dissector: PANA
From: "ronnie sahlberg" <[email protected]>
Date: Wed, 5 Jul 2006 08:24:30 +0000
value_strings must be terminated with a {0,NULL} entry   or else
val_to_str and friends are likely to walk outside the array and segv.

can you break the flags field out into its own subdissector   that
also populates the expansion line.
see for example
dissect_iui_flags() in packet-fcsb3.c

can you alkso change into being a new-style dissector   that checks
heuristically whether it looks like PANA or not and returns FALSE if
not.
That will reduce the amount of false positives.
See packet-iscsi.c for examples of that.


can you create a page in the wiki for this protocol and populate it
with nice information and also upload an example trace




On 7/5/06, Peter Racz <[email protected]> wrote:
Dear developers,

I added a new dissector for the PANA (Protocol for carrying Authentication
for
Network Access) protocol, currently specified in the IETF draft
draft-ietf-pana-pana-11. The patch is attached.

Changed files:
- packet-pana.c: new file with the dissector
- Makefile.common: added packet-pana.c to DISSECTOR_SRC

Best regards,
Peter