Wireshark-dev: Re: [Wireshark-dev] listen_rtp plugin
From: "Anders Broman" <[email protected]>
Date: Tue, 27 Jun 2006 23:51:07 +0200
Hi,
I have checked in the plugin files for now there are some problems
With applying the change to the makefiles can you please redo the
Patch against the current SVN. I would also suggest to leave 
"PORTAUDIO" commented out in these first checkins.
There are also some warnings from voip_calls.c

Best regards
Anders

C:\wireshark>patch acinclude.m4 listen_rtp.patch
patching file acinclude.m4
Hunk #2 FAILED at 1592.
1 out of 2 hunks FAILED -- saving rejects to file acinclude.m4.rej
patching file config.nmake
patching file configure.in
Reversed (or previously applied) patch detected!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
6 out of 6 hunks ignored -- saving rejects to file configure.in.rej
can't find file to patch at input line 449
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|Index: gtk/voip_calls.c
|===================================================================
|--- gtk/voip_calls.c   (revision 18459)
|+++ gtk/voip_calls.c   (working copy)
--------------------------
File to patch: gtk/voip_calls.c
patching file gtk/voip_calls.c
can't find file to patch at input line 509
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|Index: gtk/voip_calls_dlg.c
|===================================================================
|--- gtk/voip_calls_dlg.c       (revision 18459)
|+++ gtk/voip_calls_dlg.c       (working copy)
--------------------------
File to patch: gtk/voip_calls_dlg.c
patching file gtk/voip_calls_dlg.c
patching file Makefile.am
Hunk #3 succeeded at 238 (offset 1 line).
Hunk #4 succeeded at 258 (offset 1 line).
patching file Makefile.nmake
patching file Makefile.nmake
Hunk #1 FAILED at 18.
Hunk #2 FAILED at 90.
Hunk #3 FAILED at 193.
Hunk #4 FAILED at 252.
Hunk #5 FAILED at 303.
Hunk #6 FAILED at 353.
6 out of 6 hunks FAILED -- saving rejects to file Makefile.nmake.rej
patching file Makefile.am
Hunk #1 FAILED at 28.
Hunk #2 FAILED at 47.
2 out of 2 hunks FAILED -- saving rejects to file Makefile.am.rej
patching file Makefile.am
Hunk #1 FAILED at 28.
Hunk #2 FAILED at 47.
2 out of 2 hunks FAILED -- saving rejects to file Makefile.am.rej
patching file Makefile.nmake
Hunk #1 FAILED at 18.
Hunk #2 FAILED at 90.
Hunk #3 FAILED at 193.
Hunk #4 FAILED at 252.
Hunk #5 FAILED at 303.
Hunk #6 FAILED at 353.
6 out of 6 hunks FAILED -- saving rejects to file Makefile.nmake.rej

C:\wireshark>

voip_calls.c
voip_calls.c(499) : warning C4090: 'function' : different 'const' qualifiers
voip_calls.c(499) : warning C4024: 'function through pointer' : different
types
for formal and actual parameter 2
voip_calls.c(499) : warning C4133: 'function' : incompatible types - from
'struc
t _packet_info *' to 'struct _proto_node *'
sctp_assoc_analyse.c
voip_calls_dlg.c
voip_calls_dlg.c(413) : warning C4133: 'function' : incompatible types -
from 's
truct _voip_calls_tapinfo *' to 'struct tvbuff *'
Generating Code...

-----Ursprungligt meddelande-----
Från: [email protected]
[mailto:[email protected]] För Alejandro Vaquero
Skickat: den 27 juni 2006 05:38
Till: [email protected]
Ämne: [Wireshark-dev] listen_rtp plugin

Hi All,
    Here is the "listen_rtp" plugin that allows to listen audio RTP 
conversations.

    The plugin is integrated to the "Voip Calls" feature. There is a new 
"listen" button in the "Voip Calls" that once the calls are selected and 
the "listen" is clicked, a new window will open. In this window you can 
change the simulated jitter buffer to be used for decoding the RTP 
packets. In this first implementation, only a static jitter buffer can 
be simulated. Then pressing "decode" will decode all the RTP and 
generate the graphical view of the audio channels. From there you can 
select up to two channels at the same time (to be played in the left and 
right channels) and then play, pause, stop,etc.....ok, the attached 
screenshot it is self explanatory (hopefully).
    The only codecs available from now are G711u and G711a law.

    The PortAudio (www.portaudio.com) library is used to play audio. 
This is an open source cross-platform Audio library. I have tested this 
on Windows XP  and in a linux FC4.

    I modified the Makefile.nmake and Makfile.am files, acinclude.m4, 
config.nmake and configure.in to be compiled in Windows VC6 and Linux 
(thanks Luis for the lua staff as I was totally lost here). Not sure 
what else it is needed for other platforms.
    For windows, the user can comment the PORTAUDIO_DIR parameter in the 
config.nmake file to avoid the plugin to be compiled.
    For linux, by default the plugin is not compiled unless the user 
uses the "--with-portaudio" argument when running "configure". To be 
compiled in linux, the "portaudio" package needs to be installed.

    The attached files contain:
listen_rtp.patch: this is a patch that has the changes for the "Voip 
Calls" files, and all the Makefiles and auto staff.
listen_rtp.zip: the plugin files to be added to the plugin directory
portaudio_v18_1.zip: this file is the PortAudio Window library that need 
to be downloaded when using "nmake -f Makefile setup".
listen_rtp_screenshot.png: A screen shot of the plugin.

TODO:
   - Tests in other platforms.
    - Make the changes in the Windows installer, to have the option to 
install it or not (same as the Lua plugin). I don't know where to start 
looking for this.
 
    Any comment or enhancement are very welcome.

Regards
Alejandro