Wireshark-dev: Re: [Wireshark-dev] SSL + DTLS
From: "authesserre samuel" <[email protected]>
Date: Tue, 27 Jun 2006 17:43:46 +0200
the SSL dissector was made by paolo abeni so structure was chosen by him,

if I change DTLS plugin the problem will stay in SSL. am I rigth ?

I have to change twice ?

(before starting working I would like to know exactly where is the
problem because the patch modify the two dissectors)

regards,

On 6/27/06, ronnie sahlberg <[email protected]> wrote:
also if you can get rid of the debug statements   unless you really need them.



On 6/27/06, ronnie sahlberg <[email protected]> wrote:
> Checked in.
>
>
> Can you make these additional changes :
>
> 1, replace the GHashTables with se_tree binary trees?   see emem.h and
> README.malloc
>
> 2, have a look at and update the wiki?    I added an example capture
> from one of your emails to the list to the wiki.
>
>
>
> On 6/15/06, authesserre samuel <[email protected]> wrote:
> > Hi,
> >
> > enclosed find the new patch made on svn ....
> >
> > it make the same that I've say last mail but since I've found another
> > error in OpenSSL implementation : DTLS implementation doesn't add two
> > bytes long before Pre Master Secret in RSA key exchange (in
> > ClientKeyExchange message..)
> >
> > I've corrected Version problem and this problem in openssl and I will
> > send a patch tomorrow
> > (I've done the correction in DTLS dissector too)
> > If my corrections will be integrated I send here new patch.(If I have
> > enougth time I would like to implement that's missing in DTLS
> > implementation like replay or packet loss handling)
> >
> > My problem is integration in wireshark because a lot of things in DTLS
> > and SSL dissectors are same and I don't know how to make the code
> > maintainable (Ive put things in packet-ssl-utils but I don't know if
> > it is a good choice...). The DTLS dissector is a copy of SSL dissector
> > that I adapted...but I don't know how I can do otherwise
> >
> > regards,
> >
> > Samuel
> >
> >
> >
> >
> > On 6/14/06, Joerg Mayer <[email protected]> wrote:
> > > On Mon, Jun 12, 2006 at 04:52:15PM +0200, authesserre samuel wrote:
> > > > >It's a new patch (and certainly the last of me) for SSL and DTLS
> > > > >decryption.
> > > > >The SSL one isn't new, it correct some bugs .... (like alert
> > decryption)
> > >
> > > I tried to apply your patch to current wireshark svn, and it failed.
> > > Can you please recreate it against the current svn sources?
> > >
> > > Thanks
> > >        Joerg
> > > _______________________________________________
> > > Ethereal-dev mailing list
> > > [email protected]
> > > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> > >
> >
> >
> > --
> > ++++++++++++++++++++++++++
> > + Authesserre Samuel            +
> > + 12 rue de la défense passive+
> > + 14000 CAEN                      +
> > + FRANCE                           +
> > + 06-27-28-13-32                   +
> > + [email protected]          +
> > ++++++++++++++++++++++++++
> >
> >
>


--
++++++++++++++++++++++++++
+ Authesserre Samuel            +
+ 12 rue de la défense passive+
+ 14000 CAEN                      +
+ FRANCE                           +
+ 06-27-28-13-32                   +
+ [email protected]          +
++++++++++++++++++++++++++