Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 18427: /trunk/ /trunk/epan/dissector

From: Martin Mathieson <martin.mathieson@xxxxxxxxxxxx>
Date: Wed, 21 Jun 2006 11:57:07 +0100
This dependency (sharing of this variable) has existed since dct2000 support was first committed (14th April).
Has it never been built on OSX-10.3-PPC?

I didn't realise I was introducing a new dependency. There is no other obvious place in the preferences to control the behaviour of a wiretap module. I like being able to control it from the relevant protocol preferences, even though a file has to be (re)-loaded to see its effect.

Is changing the Windows makefiles as Tomas suggested acceptable? If not, are there any suggestions for how I might make this preference work on all platforms?

Best regards,

Kukosa, Tomas wrote:


sharing catapult_dct2000_board_ports_only variable between libwireshark
and wiretap causes problem in Windows linking. It seems it is the 1st dependency between libwireshark and wiretap.
If there is no other solution Windows makefiles has to be changed.

I could do it but I am not sure when.

-----Original Message-----
From: wireshark-commits-bounces@xxxxxxxxxxxxx
[mailto:wireshark-commits-bounces@xxxxxxxxxxxxx] On Behalf Of
Sent: Sunday, June 11, 2006 10:27 AM
To: wireshark-commits@xxxxxxxxxxxxx
Subject: [Wireshark-commits] rev 18427: /trunk/ /trunk/epan/dissectors/:
packet-catapult-dct2000.c /trunk/: Makefile.am /trunk/wiretap/:


User: etxrab
Date: 2006/06/11 08:26 AM

From Martin Mathieson:
This patch:
- treats the variant field as a variable-length string field. This is needed for some of the more complicated protocols where the variant number of the embedded protocol is also represented

- the patch to Makefile.am was not applied from http://www.wireshark.org/lists/wireshark-dev/200606/msg00009.html

Directory: /trunk/epan/dissectors/
 Changes    Path                         Action
 +11 -9     packet-catapult-dct2000.c    Modified

Directory: /trunk/
 Changes    Path           Action
 +5 -2      Makefile.am    Modified

Directory: /trunk/wiretap/
 Changes    Path                  Action
 +9 -12     catapult_dct2000.c    Modified

Wireshark-commits mailing list
Wireshark-dev mailing list