Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-commits: [Wireshark-commits] master-2.6 67c8c7e: Fix reassembly of larger TACACS+ account

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Nov 2018 08:30:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67c8c7e03ba638a1d0006e250f851c7db2cc805d
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

67c8c7e by Jason Cohen (kryojenik2@xxxxxxxxx):

    Fix reassembly of larger TACACS+ accounting messages
    
    Since TACACS+ is TCP only, switched to tcp_dissect_pdus
    
    Bug: 15293
    Change-Id: I8cee8a1f474ae866c59f94ec8ecbd412e5189e89
    Reviewed-on: https://code.wireshark.org/review/30748
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/30749
    

Actions performed:

    from  13d2102   Fix expert info message for wrong option length.
     add  67c8c7e   Fix reassembly of larger TACACS+ accounting messages


Summary of changes:
 epan/dissectors/packet-tacacs.c | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)