URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d631c17eee0ade675f6f4a0612ce0b127e44ee72
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
d631c17 by Peter Wu (peter@xxxxxxxxxxxxx):
test: convert suite_dfilter to use fixtures
Stop using subprocesstest, drop the (now redundant) DFTestCase base
class and use pytest-style fixtures to inject the dependency on tshark.
This approach makes it easier to switch to pytest in the future.
Most substitutions were automated, so no typos should be present.
Change-Id: I3516029162f87423816937410ff63507ff82e96f
Reviewed-on: https://code.wireshark.org/review/30649
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from d38ab1b test: convert suite_nameres to use fixtures
add d631c17 test: convert suite_dfilter to use fixtures
Summary of changes:
test/fixtures_ws.py | 12 +--
test/suite_dfilter/dfiltertest.py | 53 ++++++----
test/suite_dfilter/group_bytes_ether.py | 104 ++++++++++---------
test/suite_dfilter/group_bytes_ipv6.py | 104 ++++++++++---------
test/suite_dfilter/group_bytes_type.py | 16 +--
test/suite_dfilter/group_double.py | 62 +++++------
test/suite_dfilter/group_integer.py | 154 ++++++++++++++--------------
test/suite_dfilter/group_integer_1byte.py | 15 +--
test/suite_dfilter/group_ipv4.py | 131 ++++++++++++------------
test/suite_dfilter/group_membership.py | 44 ++++----
test/suite_dfilter/group_range_method.py | 32 +++---
test/suite_dfilter/group_scanner.py | 32 +++---
test/suite_dfilter/group_string_type.py | 164 +++++++++++++++---------------
test/suite_dfilter/group_stringz.py | 20 ++--
test/suite_dfilter/group_time_relative.py | 20 ++--
test/suite_dfilter/group_time_type.py | 72 ++++++-------
test/suite_dfilter/group_tvb.py | 51 +++++-----
test/suite_dfilter/group_uint64.py | 16 +--
18 files changed, 586 insertions(+), 516 deletions(-)
