URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1fe542459cfcac79f1d2e4564145014713dacc8c
Submitter: "Dario Lombardo <lomato@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
1fe5424 by Dario Lombardo (lomato@xxxxxxxxx):
tds: use %lf instead of G_GINT64_MODIFIER for text.
On many platforms, G_GINT64_MODIFIER is "ll", that gives an error when used with
the float modifier:
../epan/dissectors/packet-tds.c:2270:55: error: length modifier 'll' results in undefined behavior or no effect with 'f' conversion specifier [-Werror,-Wformat]
proto_item_append_text(item, " (%"G_GINT64_MODIFIER"f)", tvb_get_letohieee_float(tvb, *offset));
~~^~~~~~~~~~~~~~~~~~~
/usr/local/Cellar/glib/2.58.1/lib/glib-2.0/include/glibconfig.h:56:28: note: expanded from macro 'G_GINT64_MODIFIER'
#define G_GINT64_MODIFIER "ll"
^
1 error generated.
The solution appears to revert back to %lf.
Fixes: v2.9.0rc0-2411-gdbe2d081ec
Change-Id: I470cc5395921abc14aedd501f27881d5c21c618f
Reviewed-on: https://code.wireshark.org/review/30487
Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
Tested-by: Dario Lombardo <lomato@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
Actions performed:
from 89d7423 extcap: use the correct values for comparing.
add 1fe5424 tds: use %lf instead of G_GINT64_MODIFIER for text.
Summary of changes:
epan/dissectors/packet-tds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
