Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-commits: [Wireshark-commits] master 54b58c5: mmdb: do not lock the pipe mutex recursively

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 01 Nov 2018 06:26:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=54b58c5320ff2b524c94eb763a110f9448dd9ad3
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

54b58c5 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    mmdb: do not lock the pipe mutex recursively
    
    According to GLib documentation, take twice the lock in the same thread
    leads to undefined behavior (and could lead to deadlocks).
    
    Change-Id: I40e02ba9d619eb1db2a04f2be54c461c817b15ff
    Reviewed-on: https://code.wireshark.org/review/30446
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0457e60   FT_BYTES: fix dissection of FT_BYTES when using SEP_SPACE and "NONE" options
     add  54b58c5   mmdb: do not lock the pipe mutex recursively


Summary of changes:
 epan/maxmind_db.c | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)