Wireshark · Wireshark-commits: [Wireshark-commits] master-2.4 75da4c3: print.c: Print FT_CHAR fields as FT_UINT8

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75da4c348fe02f8866dcf49f0486c365c6a2509c
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

75da4c3 by Vasil Velichkov (vvvelichkov@xxxxxxxxx):

    print.c: Print FT_CHAR fields as FT_UINT8
    
    This fixes the following asserts
    
     #2  0x00007ffff0d270f3 in g_assertion_message (domain=0x0, file=0x7ffff4e11f90 "/home/vasko/sources/wireshark/epan/print.c", line=598, func=0x7ffff4e12e20 <__func__.18585> "proto_tree_write_node_pdml",
         message=0x555555aaab70 "code should not be reached") at gtestutils.c:2532
     #3  0x00007ffff0d8015e in g_assertion_message_expr () at gtestutils.c:2555
    
     #2  0x00007ffff0d270f3 in g_assertion_message (domain=0x0, file=0x7ffff4e11f90 "/home/vasko/sources/wireshark/epan/print.c", line=983,
         func=0x7ffff4e12e40 <__func__.18697> "write_json_proto_node_hex_dump", message=0x555555aac9d0 "code should not be reached") at gtestutils.c:2532
     #3  0x00007ffff0d8015e in g_assertion_message_expr () at gtestutils.c:2555
     #4  0x00007ffff39a8f87 in write_json_proto_node_hex_dump (node=0x7fffdc86e550, data=0x7fffffffce60) at /home/vasko/sources/wireshark/epan/print.c:983
    
     #2  0x00007ffff0d270f3 in g_assertion_message (domain=0x0, file=0x7ffff4e12010 "/home/vasko/sources/wireshark/epan/print.c", line=1299,
         func=0x7ffff4e12ef0 <__func__.18804> "ek_write_hex", message=0x555555aac290 "code should not be reached") at gtestutils.c:2532
     #3  0x00007ffff0d8015e in g_assertion_message_expr () at gtestutils.c:2555
     #4  0x00007ffff39a9a32 in ek_write_hex (fi=0x7fffdc86e4e0, pdata=0x7fffffffce90) at /home/vasko/sources/wireshark/epan/print.c:1299
    
    Bug: 15088
    Change-Id: I48a7e87863fb6708cd668582a240e5ba71d1b5a0
    Reviewed-on: https://code.wireshark.org/review/28891
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 82454b82c577ffdcc87fb66b03a41cd793a668af)
    Conflicts:
    	epan/print.c
    Reviewed-on: https://code.wireshark.org/review/29334
    

Actions performed:

    from  c9669fc   Update the release notes for 2.4.9.
     add  75da4c3   print.c: Print FT_CHAR fields as FT_UINT8


Summary of changes:
 epan/print.c | 3 +++
 1 file changed, 3 insertions(+)