ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] master 4802e33: HTTP: ignore large Content-Length values

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Aug 2018 07:57:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4802e3300dc18a973f74990d0d3f96068a7759d1
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4802e33 by Peter Wu (peter@xxxxxxxxxxxxx):

    HTTP: ignore large Content-Length values
    
    The SSTP capture from bug 8239 failed to be recognized as SSTP.  Its
    large Content-Length was parsed as -1 which triggered reassembly due to
    tvb_bytes_exist returning FALSE for negative lengths.
    
    Test:
    
        # Expect 'SSTP_DUPLEX_POST /' in the output of:
        tshark -r sstp.pcapng -ossl.keys_list:localhost,443,http,sstp.pem, -Y frame.number==174 -Px
    
    Change-Id: I40afaff8554f34f24e09bab184121ced59045954
    Fixes: v2.9.0rc0-531-gd80acae40d ("tvbuff: make tvb_bytes_exist fail with negative values")
    Reviewed-on: https://code.wireshark.org/review/29109
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  149e74b   Put the interface descrptions into the IDB when capturing to pcapng.
     add  4802e33   HTTP: ignore large Content-Length values


Summary of changes:
 epan/req_resp_hdrs.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)