ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] master-2.4 cfb4f50: More interface view cleanups.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Aug 2018 02:04:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cfb4f50f1dcf169c7749dc2d8938ae53e6e37c9e
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

cfb4f50 by Guy Harris (guy@xxxxxxxxxxxx):

    More interface view cleanups.
    
    Rename some of the columns - IFTREE_COL_NAME is the interface name,
    IFTREE_COL_DESCRIPTION is the description/friendly name, and a new
    IFTREE_COL_DISPLAY_NAME column is the display name (which may include
    both the description and the interface name).  Rename
    IFTREE_COL_INTERFACE_COMMENT to just IFTREE_COL_COMMENT - there's no
    *other* type of comment, and "IF" is short for "interface".
    
    In the interface frame, use IFTREE_COL_DISPLAY_NAME, as that's the only
    column that shows both and thus has something for all interfaces.
    
    In the "Manage interfaces" dialog, put the description before the
    interface name, as it was in earlier versions.
    
    Change-Id: If0d959dcd4ca99913c941df00621da3c478233f6
    Reviewed-on: https://code.wireshark.org/review/29090
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 991f5a6e858ea116cb938c9acacee415ee075bab)
    Reviewed-on: https://code.wireshark.org/review/29092
    

Actions performed:

    from  9616081   Show just the description in the description column.
     add  cfb4f50   More interface view cleanups.


Summary of changes:
 ui/qt/interface_frame.cpp            |  8 ++++----
 ui/qt/interface_tree_cache_model.cpp |  6 +++---
 ui/qt/interface_tree_model.cpp       | 20 ++++++++++++++------
 ui/qt/interface_tree_model.h         |  5 +++--
 ui/qt/manage_interfaces_dialog.cpp   |  6 +++---
 5 files changed, 27 insertions(+), 18 deletions(-)