ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] master-2.2 183063c: Fix two warnings when compiling with rpc

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 11 Aug 2018 19:19:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=183063ce65d86b3bfa29bdb060c2a9bbb28ae474
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.2
Repository: wireshark

Commits:

183063c by Joerg Mayer (jmayer@xxxxxxxxx):

    Fix two warnings when compiling with rpcap support on macOS.
    
    One is an unused variable warning turning error, the other is
    
    [ 71%] Building C object ui/CMakeFiles/ui.dir/recent.c.o
    /Users/jmayer/worktmp/wireshark/git/ui/recent.c:494:23: error: implicit conversion loses integer precision:
          'glong' (aka 'long') to 'gint' (aka 'int') [-Werror,-Wshorten-64-to-32]
          rh->auth_type = auth_type;
                        ~ ^~~~~~~~~
    1 error generated.
    
    Please review.
    
    Change-Id: If838f8fa1e8a76dc8c6cc78db495befdd527da92
    Reviewed-on: https://code.wireshark.org/review/18544
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    (cherry picked from commit 42f0695f4d84093a1617ee1f35ee724aa4d98166)
    Reviewed-on: https://code.wireshark.org/review/29077
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7bef5c7   Make a routine static that's not used outside its source file.
     add  183063c   Fix two warnings when compiling with rpcap support on macOS.


Summary of changes:
 ui/qt/remote_capture_dialog.cpp | 2 --
 ui/recent.c                     | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)